Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible Core version bump up to 2.14.0 #452

Merged
merged 38 commits into from
Mar 28, 2024
Merged

Ansible Core version bump up to 2.14.0 #452

merged 38 commits into from
Mar 28, 2024

Conversation

bhati-pradeep
Copy link
Collaborator

@bhati-pradeep bhati-pradeep commented Dec 11, 2023 •
edited
Loading

Updated runtime.yml to only support ansible >=2.14.0, as previous versions are EOL

Below requirements Version changed to:
ansible-core==2.14.0
coverage==6.5.0

Changes:

  • Fixed doc lint issues which came up due to requirements changes.
  • Removed all pipeline tests for python < 3.9
  • Updated requirements.txt for integration tests to use 2.14.0
  • Fixed lints related to trailing spaces and extra lines.

This was linked to issues Jan 4, 2024
[Imprv] Bumpup ansible core versions to avoid EOL versions #457
Closed
[Imprv] Add ansible-lint checks for Pull requests #458
Open
@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Jan 4, 2024 •
edited
Loading

ansible-lint pipeline job and failures will be taken up in another PR . This PR only verify the version bump related lint failures.

@bhati-pradeep bhati-pradeep removed a link to an issue Jan 4, 2024
[Imprv] Add ansible-lint checks for Pull requests #458
Open
@bhati-pradeep
Copy link
Collaborator Author

ok-to-test

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Mar 13, 2024 •
edited
Loading

/ok-to-test

--> Failed due to PAT having improper permissions

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Mar 13, 2024 •
edited by github-actions bot
Loading

/ok-to-test

Integration test run status is : cancelled
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/8264889441

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Mar 13, 2024 •
edited by github-actions bot
Loading

/ok-to-test

Integration test run status is : cancelled
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/8265811780

@bhati-pradeep bhati-pradeep changed the title Version bump for runtime.yml Ansible Core version bump to 2.14.0 Mar 13, 2024
@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Mar 13, 2024 •
edited
Loading

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/8265996426

All PC and karbon related tests were run against v2023.1.0.2 and vkarbon 2.8.0. All passed except:
Tests failed:
nutanix_pbrs -> Have fixed and ran test locally which are passing. Failed due to incorrect test checks. Have pushed some fixes: d90b687

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Mar 14, 2024 •
edited
Loading

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/8285267374

Coverage failure.

All PC tests with 2023.1.0.2, karbon 2.8 and NDB sanity with v2.5.2 passed.

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Mar 15, 2024 •
edited
Loading

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/8297504787

Ran foundation sanity tests with v5.2
Node imaging passed. Creation of cluster failed due to genesis failures not related to nutanix ansible provider.

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Mar 15, 2024 •
edited by github-actions bot
Loading

/ok-to-test

Integration test run status is : success
Converage is : 86 %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/8299397803

@bhati-pradeep bhati-pradeep changed the title Ansible Core version bump to 2.14.0 Ansible Core version bump up to 2.14.0 Mar 15, 2024
@bhati-pradeep
Copy link
Collaborator Author

/ok-to-test

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Mar 15, 2024 •
edited
Loading

/ok-to-test

Integration test run status is : success
Converage is : 86 %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/8301673157

Final regression with PC tests on setup with PC version 2023.1.0.2

@premkarat premkarat merged commit 03d0974 into main Mar 28, 2024
7 checks passed
george-ghawali pushed a commit that referenced this pull request Sep 19, 2024
@bhati-pradeep @george-ghawali
Ansible Core version bump up to 2.14.0 (#452)
85b60a2 
* Version bump for runtime.yml

* Dummy commit

* Add ansible lint check

* Requirements bumpup ansible-core version

* Workflow should only have 3.9 as 3.8 and 3.7 support is gone from ansible

* Revert pipeline changes

* Revert sanity version changes

* Change ansible-core to 2.14.0

* Use python 3.9 only and use ubuntu 20.4 runner for ansible unit tests

* Doc fixes

* 1. Bump up coverage.
2. Lint fixes

* Add notes in inventory modules

* Minor lint fixes

* notes lint fix

* Fix notes lint faulure

* Fix trailing spaces

* More lint fixes

* More lint fixes

* Remove ansible lint check

* Fix fetch_url for ansible versions >= 2.13.0

* Install community package before inetegration tests

* Fix integration requirements.txt

* print ansible version in pipeliines

* Update source branch of ok to test

* revert workflows temp changes

* Not run foundation and ndb sanity test

* Fix PBRS tests. Add correct value types for code and type in icmp spec

* Enable NDB sanity tests

* Fix read me typos

* Enable foundation sanity and some lint fixes

* Add bond modes in test for foundation

* Disable pc tests

* Minor fix

* Revert "Disable pc tests"

This reverts commit be1a11d.

* Disabled foundation and database to run only PC tests

* Release notes update

* Lint fxies

* Change log changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premkarat premkarat premkarat approved these changes

Assignees
No one assigned
Labels
⚙ ci 📝 documentation 🐍 python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Imprv] Bumpup ansible core versions to avoid EOL versions
2 participants
@bhati-pradeep @premkarat